stop using mock blockchain - was causing data race#445
Open
freemans13 wants to merge 1 commit intobsv-blockchain:mainfrom
Open
stop using mock blockchain - was causing data race#445freemans13 wants to merge 1 commit intobsv-blockchain:mainfrom
freemans13 wants to merge 1 commit intobsv-blockchain:mainfrom
Conversation
Contributor
|
🤖 Claude Code Review Status: Complete Issue Found: Line 3082 adds a mock for a method that doesn't exist on the blockchain interface. Details:
See inline comment for details. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| mockBlockchain.On("SetBlockSubtreesSet", mock.Anything, mock.Anything).Return(nil) | ||
| mockBlockchain.On("GetBestBlockHeader", mock.Anything).Return(&model.BlockHeader{}, &model.BlockHeaderMeta{Height: 100}, nil) | ||
|
|
||
| mockBlockchain.On("ReValidateBlock", mock.Anything, mock.Anything).Return() |
Contributor
There was a problem hiding this comment.
This mock line is incorrect and unnecessary. ReValidateBlock is a method on BlockValidation itself (BlockValidation.go:1631), not on the blockchain client interface. The blockchain interface has RevalidateBlock (lowercase v) at Interface.go:508. Remove this line.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.