Open
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Summary
Adds a new LAUNCHING FSM state to fix a race condition where subtree validation could process transactions for future blocks during node catchup, causing "Coinbase UTXO can only be spent when it matures" errors.
Problem
During node catchup, the following race condition occurred:
Solution
Add a new intermediate LAUNCHING state that:
New FSM Flow
LEGACYSYNC Path (Unchanged)
LEGACYSYNC is a separate path that bypasses LAUNCHING entirely:
This is intentional because legacy sync connects to old Bitcoin SV nodes and has its own sync mechanism built-in.
Changes
Core FSM Changes
LAUNCHINGstate (value 4) andLAUNCHevent (value 4)Launch()gRPC handler; auto-transition LAUNCHING→RUNNING in test modeLaunch()toClientIinterfaceFSMStateLAUNCHING,FSMEventLAUNCHconstants andLaunch()methodLaunch()implementationsService Updates
Test Infrastructure
LocalTestStartFromStateto "LAUNCHING"Launch()thenRun()for proper FSM transitionsLaunch()to mock clientsDashboard UI
Testing
Test Mode Behavior
When
LocalTestStartFromState = "LAUNCHING", the blockchain service:This ensures tests run with FSM in RUNNING state while still validating the LAUNCHING→RUNNING transition.
Breaking Changes
Run()is no longer valid from IDLE state - must useLaunch()firstLocalTestStartFromStatecan only be "IDLE" or "LAUNCHING", not "RUNNING"🤖 Generated with Claude Code