Skip to content

Conversation

@sirdeggen
Copy link
Collaborator

Description of Changes

Provide a brief description of the changes you've made.

Linked Issues / Tickets

Reference any related issues or tickets, e.g. "Closes #123".

Testing Procedure

Describe the tests you've added or any testing steps you've taken.

  • I have added new unit tests
  • All tests pass locally
  • I have tested manually in my local environment

Checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have updated CHANGELOG.md with my changes
  • I have run npm run doc and npm run lint one final time before requesting a review
  • I have fixed all linter errors to ensure these changes are compliant with ts-standard
  • I have run npm version patch so that my changes will trigger a new version to be released when they are merged

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
5.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@codecov
Copy link

codecov bot commented Jan 27, 2026

@github-actions
Copy link

🏁 Benchmark Comparison (Node 22)

Comparing this PR (566119e) against master (167c7d5).

✅ No regressions over the 5% threshold detected.

Benchmark Metric PR Branch Master Δ Change
BigNumber Arithmetic mul large numbers 8.85 ms 9.09 ms -0.24 ms -2.64%
BigNumber Arithmetic add large numbers 1.45 ms 1.45 ms +0.00 ms 0.00%
BigNumber Serialization toSm big 2.78 ms 2.78 ms +0.00 ms 0.00%
BigNumber Serialization toSm little 2.90 ms 2.84 ms +0.06 ms +2.11%
BigNumber Serialization fromSm big 3.01 ms 2.97 ms +0.04 ms +1.35%
BigNumber Serialization fromSm little 3.05 ms 3.05 ms +0.00 ms 0.00%
BigNumber Serialization fromScriptNum 3.06 ms 3.08 ms -0.02 ms -0.65%
Script Serialization Big script round trip 3.75 ms 3.80 ms -0.05 ms -1.32%
Transaction Verification deep chain verify 559.76 ms 559.57 ms +0.19 ms +0.03%
Transaction Verification wide transaction verify 571.99 ms 573.75 ms -1.76 ms -0.31%
Transaction Verification large tx verify 284.64 ms 283.46 ms +1.18 ms +0.42%
Transaction Verification nested inputs verify 157.32 ms 157.05 ms +0.27 ms +0.17%
Symmetric Key encrypt large 2MB 1727.51 ms 1757.75 ms -30.24 ms -1.72%
Symmetric Key decrypt large 2MB 1679.78 ms 1711.52 ms -31.74 ms -1.85%
Symmetric Key encrypt 50 small 7.49 ms 7.52 ms -0.03 ms -0.40%
Symmetric Key decrypt 50 small 7.09 ms 7.13 ms -0.04 ms -0.56%
Symmetric Key encrypt 200 medium 179.20 ms 183.42 ms -4.22 ms -2.30%
Symmetric Key decrypt 200 medium 174.56 ms 178.12 ms -3.56 ms -2.00%
Reader & Writer mixed ops 0.22 ms 0.22 ms +0.00 ms 0.00%
Reader & Writer large payloads 26.38 ms 26.29 ms +0.09 ms +0.34%
Reader & Writer 3000 small payloads 1.68 ms 1.72 ms -0.04 ms -2.33%
Reader & Writer 400 medium payloads 14.68 ms 14.55 ms +0.13 ms +0.89%
Atomic BEEF Transaction.toAtomicBEEF 1.69 ms 1.72 ms -0.03 ms -1.74%
Atomic BEEF Transaction.fromAtomicBEEF 3.73 ms 3.81 ms -0.08 ms -2.10%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants