Skip to content

Conversation

@jackielu3
Copy link
Collaborator

Description of Changes

Provide a brief description of the changes you've made.

Linked Issues / Tickets

Reference any related issues or tickets, e.g. "Closes #123".

Testing Procedure

Describe the tests you've added or any testing steps you've taken.

  • I have added new unit tests
  • All tests pass locally
  • I have tested manually in my local environment

Checklist

  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have updated CHANGELOG.md with my changes
  • I have run npm run doc and npm run lint one final time before requesting a review
  • I have fixed all linter errors to ensure these changes are compliant with ts-standard
  • I have run npm version patch so that my changes will trigger a new version to be released when they are merged

@jackielu3 jackielu3 requested a review from ty-everett January 26, 2026 20:04
@sonarqubecloud
Copy link

@codecov
Copy link

codecov bot commented Jan 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@ty-everett ty-everett merged commit f448c71 into 2.0.0 Jan 26, 2026
7 checks passed
@ty-everett ty-everett deleted the fix/rm-peer-timeout branch January 26, 2026 20:07
@github-actions
Copy link

🏁 Benchmark Comparison (Node 22)

Comparing this PR (1cec913) against master (92ccb0b).

✅ No regressions over the 5% threshold detected. 🎉 2 significant speedups (>5% faster).

Speedups

  • 🎉 Atomic BEEF – Transaction.toAtomicBEEF is 14.29% faster (1.50 ms vs 1.75 ms).
  • 🎉 Atomic BEEF – Transaction.fromAtomicBEEF is 14.15% faster (3.64 ms vs 4.24 ms).
Benchmark Metric PR Branch Master Δ Change
BigNumber Arithmetic mul large numbers 8.94 ms 8.87 ms +0.07 ms +0.79%
BigNumber Arithmetic add large numbers 1.48 ms 1.49 ms -0.01 ms -0.67%
BigNumber Serialization toSm big 2.97 ms 2.97 ms +0.00 ms 0.00%
BigNumber Serialization toSm little 3.04 ms 2.98 ms +0.06 ms +2.01%
BigNumber Serialization fromSm big 3.10 ms 3.16 ms -0.06 ms -1.90%
BigNumber Serialization fromSm little 3.22 ms 3.19 ms +0.03 ms +0.94%
BigNumber Serialization fromScriptNum 3.23 ms 3.23 ms +0.00 ms 0.00%
Script Serialization Big script round trip 3.90 ms 3.96 ms -0.06 ms -1.52%
Transaction Verification deep chain verify 565.27 ms 563.84 ms +1.43 ms +0.25%
Transaction Verification wide transaction verify 577.25 ms 576.13 ms +1.12 ms +0.19%
Transaction Verification large tx verify 286.12 ms 284.84 ms +1.28 ms +0.45%
Transaction Verification nested inputs verify 159.39 ms 159.50 ms -0.11 ms -0.07%
Symmetric Key encrypt large 2MB 1747.63 ms 1773.23 ms -25.60 ms -1.44%
Symmetric Key decrypt large 2MB 1710.23 ms 1720.04 ms -9.81 ms -0.57%
Symmetric Key encrypt 50 small 7.57 ms 7.72 ms -0.15 ms -1.94%
Symmetric Key decrypt 50 small 7.23 ms 7.28 ms -0.05 ms -0.69%
Symmetric Key encrypt 200 medium 182.64 ms 185.77 ms -3.13 ms -1.68%
Symmetric Key decrypt 200 medium 179.66 ms 180.15 ms -0.49 ms -0.27%
Reader & Writer mixed ops 0.22 ms 0.23 ms -0.01 ms -4.35%
Reader & Writer large payloads 29.11 ms 28.12 ms +0.99 ms +3.52%
Reader & Writer 3000 small payloads 1.80 ms 1.82 ms -0.02 ms -1.10%
Reader & Writer 400 medium payloads 16.16 ms 16.23 ms -0.07 ms -0.43%
Atomic BEEF Transaction.toAtomicBEEF 1.50 ms 1.75 ms -0.25 ms -14.29%
Atomic BEEF Transaction.fromAtomicBEEF 3.64 ms 4.24 ms -0.60 ms -14.15%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants