Skip to content

Conversation

@unmultimedio
Copy link
Member

@unmultimedio unmultimedio commented Nov 27, 2025

@github-actions
Copy link

github-actions bot commented Nov 27, 2025

The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedDec 2, 2025, 4:28 PM

@@ -0,0 +1 @@
bf2ce591fdd45d380342426ba64d3165ac504cdd
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First commit with the required import files: https://buf.build/googleapis/googleapis/commits/commit/004180b77378443887d3b55cabc00384

Label present here.

Comment on lines +1 to +19
+ LICENSE

+ cloud/run/v2/build.proto
+ cloud/run/v2/condition.proto
+ cloud/run/v2/execution.proto
+ cloud/run/v2/execution_template.proto
+ cloud/run/v2/instance_split.proto
+ cloud/run/v2/job.proto
+ cloud/run/v2/k8s.min.proto
+ cloud/run/v2/revision.proto
+ cloud/run/v2/revision_template.proto
+ cloud/run/v2/service.proto
+ cloud/run/v2/status.proto
+ cloud/run/v2/task.proto
+ cloud/run/v2/task_template.proto
+ cloud/run/v2/traffic_target.proto
+ cloud/run/v2/vendor_settings.proto
+ cloud/run/v2/worker_pool.proto
+ cloud/run/v2/worker_pool_revision_template.proto
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Module test-synced including all these files:

Image

@unmultimedio unmultimedio marked this pull request as ready for review December 1, 2025 21:36
Comment on lines +21 to +22
+ */
- *

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not familiar with this syntax, what does this do?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is rsync syntax, and iirc it means to take into account al directories' contents, but not copy them (eg none of the filepaths in this file contain the google dir, but they're still recognized and synced).

This is copied and modified from the googleapis/googleapis/rsync.incl.

Most of the rsync.incl that "don't include all protos" have it at the end. For the ones that just "include all protos", they have instead:

+ **/
+ *.proto
- *

See related https://news.ycombinator.com/item?id=25006665

@unmultimedio unmultimedio merged commit 62eb82e into main Dec 2, 2025
5 checks passed
@unmultimedio unmultimedio deleted the jfigueroa/add-googleapis-cloud branch December 2, 2025 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants