-
Notifications
You must be signed in to change notification settings - Fork 1
Add managed module googleapis/cloud-run
#1104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
| @@ -0,0 +1 @@ | |||
| bf2ce591fdd45d380342426ba64d3165ac504cdd | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First commit with the required import files: https://buf.build/googleapis/googleapis/commits/commit/004180b77378443887d3b55cabc00384
Label present here.
| + LICENSE | ||
|
|
||
| + cloud/run/v2/build.proto | ||
| + cloud/run/v2/condition.proto | ||
| + cloud/run/v2/execution.proto | ||
| + cloud/run/v2/execution_template.proto | ||
| + cloud/run/v2/instance_split.proto | ||
| + cloud/run/v2/job.proto | ||
| + cloud/run/v2/k8s.min.proto | ||
| + cloud/run/v2/revision.proto | ||
| + cloud/run/v2/revision_template.proto | ||
| + cloud/run/v2/service.proto | ||
| + cloud/run/v2/status.proto | ||
| + cloud/run/v2/task.proto | ||
| + cloud/run/v2/task_template.proto | ||
| + cloud/run/v2/traffic_target.proto | ||
| + cloud/run/v2/vendor_settings.proto | ||
| + cloud/run/v2/worker_pool.proto | ||
| + cloud/run/v2/worker_pool_revision_template.proto |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Module test-synced including all these files:
| + */ | ||
| - * |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not familiar with this syntax, what does this do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is rsync syntax, and iirc it means to take into account al directories' contents, but not copy them (eg none of the filepaths in this file contain the google dir, but they're still recognized and synced).
This is copied and modified from the googleapis/googleapis/rsync.incl.
Most of the rsync.incl that "don't include all protos" have it at the end. For the ones that just "include all protos", they have instead:
+ **/
+ *.proto
- *
See related https://news.ycombinator.com/item?id=25006665
googleapis/googleapissync the missing imported files in this new module: https://buf.build/googleapis/googleapis/commits/commit/004180b77378443887d3b55cabc00384googleapis/cloud-runin the BSR syncer.