Update protocolbuffers/wellknowntypes module to include go_features.proto #798
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
doriable
approved these changes
Dec 17, 2024
Member
Author
|
@unmultimedio, did you want to cast an eye on this before I merge? |
unmultimedio
approved these changes
Dec 18, 2024
Member
unmultimedio
left a comment
unmultimedio
left a comment
There was a problem hiding this comment.
Thanks for the testing! lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of v29.1, the protobuf releases include the
google/protobuf/go_features.protoimport.So, with the next release of the
protocolbuffers/wellknowntypesmodule (v29.2 or v30.0, whichever comes next), we can stop sync'ing theprotocolbuffers/gofeaturesmodule and update the README to indicate that it is deprecated and that its contents are now available from the wellknowntypes module instead.This change is tiny. You can look through the commit history to see additional changes (all rolled back in the final commit) that show how I tested the new config and also demonstrate the correct/expected output.