Skip to content

Conversation

@app-token-modules
Copy link
Contributor

New managed modules references found. Please review.

Copy link
Member

@unmultimedio unmultimedio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After merging the PR, we can stop syncing (and even remove all trace of) gofeatures module.

I'll wait for another look from either @pkwarren or @jhump

@@ -0,0 +1,4 @@
shake256:9429c9a9bec244a5c52290f98f645dd9f8ec76b76abbe4f212100ac6375c703c2ca5d1d02162a29041ba554ef232b169d0cb931b7e78415f3e24460becc290d3 LICENSE
shake256:6c9b8f839329afc099c66371f5e6c9ad958765095db9f09517a56cb2b8246dd5c2845e024c5c22ca6b4538a453da1b7291391788f4b93f5d943f8ee61604ac93 buf.md
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the last README that will be synced, before deprecating it in the BSR.

Comment on lines +3 to +4
> This module has been **deprecated**. Use instead the `protocolbuffers/wellknowntypes` module v29.2
> or higher.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The README contains this deprecation notice

Comment on lines +24 to +25
"name": "v1.36.1",
"digest": "e24c074714bbfe83a51ec4930388d0b3e24c0052f390c92d4fcd8640ac7c67b7017f6d0643e3fb3d63e9bd359040661270cf51d1404fbea7e535cdc83d187d43"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cas dir contains only 2 new files: the new manifest and the new README. All good.

@unmultimedio unmultimedio merged commit d93b08d into main Dec 24, 2024
5 checks passed
@unmultimedio unmultimedio deleted the fetch-modules branch December 24, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants