Pause syncing gofeatures module
#809
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
pkwarren
reviewed
Dec 24, 2024
| sync_references releases prometheus client-model https://github.com/prometheus/client_model | ||
| sync_references releases protocolbuffers gofeatures https://github.com/protocolbuffers/protobuf-go src | ||
| # TODO: remove after it finishes syncing its README's deprecation notice in existing BSRs. | ||
| # sync_references releases protocolbuffers gofeatures https://github.com/protocolbuffers/protobuf-go src |
Member
There was a problem hiding this comment.
Should we remove the CODEOWNERS entry now too?
Member
Author
There was a problem hiding this comment.
No need yet, we want to be aware of any changes, although there shouldn't be any.
pkwarren
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We cannot remove all its references yet, we need to wait for the new README (with the deprecation notice) to be synced to existing BSRs.
Related to #808