Automate swift package resolve
#2162
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stefanvanburen
commented
Dec 16, 2025
internal/cmd/fetcher/main.go
Outdated
| parts := strings.Fields(gitCloneCmd) | ||
| var repoDir string | ||
| for _, part := range parts { | ||
| if strings.HasPrefix(part, "https://") { |
Member
Author
There was a problem hiding this comment.
just a heuristic for the repo in the git clone line; we can loosen this over time if it doesn't work.
Member
Author
|
Ran this on the commit before |
pkwarren
approved these changes
Dec 16, 2025
Member
pkwarren
left a comment
pkwarren
left a comment
There was a problem hiding this comment.
Overall looks good. Just a suggestion on a different approach.
pkwarren
approved these changes
Dec 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On upgrade of a Swift plugin (with a
Package.resolvedfile), clone the git repo, re-runswift package resolve, and copy thePackage.resolvedfile to the directory. Basically, an automation of the steps described in #2161.Also, bump golangci-lint to latest.
Fixes #1941.