Skip to content

Update maven publish plugin to latest #328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pkwarren merged 1 commit into from
Jul 14, 2025
Merged

Update maven publish plugin to latest #328

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import com.diffplug.gradle.spotless.SpotlessExtension
import com.vanniktech.maven.publish.JavaLibrary
import com.vanniktech.maven.publish.JavadocJar
import com.vanniktech.maven.publish.SonatypeHost
import net.ltgt.gradle.errorprone.CheckSeverity
import net.ltgt.gradle.errorprone.errorprone

Expand Down Expand Up @@ -292,7 +291,7 @@ allprojects {

mavenPublishing {
val isAutoReleased = project.hasProperty("signingInMemoryKey")
publishToMavenCentral(SonatypeHost.CENTRAL_PORTAL, automaticRelease = true)
publishToMavenCentral(automaticRelease = true)
if (isAutoReleased) {
signAllPublications()
}
Expand Down
2 changes: 1 addition & 1 deletion gradle/libs.versions.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ buf = "1.55.1"
cel = "0.9.1"
error-prone = "2.40.0"
junit = "5.13.3"
maven-publish = "0.33.0"
maven-publish = "0.34.0"
protobuf = "4.31.1"

[libraries]
Expand Down
4 changes: 2 additions & 2 deletions src/test/java/build/buf/protovalidate/FormatTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,15 +94,15 @@ public static void setUp() throws Exception {
.build();
}

@ParameterizedTest()
@ParameterizedTest
Copy link
Member Author

@pkwarren pkwarren Jul 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixes error prone warnings seen during compilation.

@MethodSource("getFormatTests")
void testFormatSuccess(SimpleTest test) throws CelValidationException, CelEvaluationException {
Object result = evaluate(test);
assertThat(result).isEqualTo(getExpectedResult(test));
assertThat(result).isInstanceOf(String.class);
}

@ParameterizedTest()
@ParameterizedTest
@MethodSource("getFormatErrorTests")
void testFormatError(SimpleTest test) {
assertThatThrownBy(() -> evaluate(test)).isInstanceOf(CelEvaluationException.class);
Expand Down