Surface soju-bouncer networks via an in-console onboarding banner - #26
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Sources/BryggaCore/PreferencesKeys.swift— newbouncerOnboardingDismissedPrefixconstant for the per-server dismissal flag (UserDefaults key suffix isserver.id).Sources/Brygga/Views/ContentView.swift:BouncerNetworkRow(file-private) fromBouncerNetworksPopoverso the popover and banner share row markup. Added an optionalonAddcallback so the popover can dismiss itself while the banner stays mounted.BouncerOnboardingBanner(server:). Visible iff (a)server.bouncerNetworksnon-empty, (b) per-serverdismissedflag is false, (c) no siblingServeralready hasbouncerNetIDmatching one of the advertised networks. Uses@AppStoragewith a runtime key built frombouncerOnboardingDismissedPrefix + server.id.ServerMessageListnow wraps itsMessageBufferViewin aVStackand mounts the banner above it.Test plan
swift build— passesswift test— 115 tests pass (no test changes; banner is UI-only and matches the precedent ofHistoryHeaderViewfrom Surface CHATHISTORY at the top of the channel buffer #21)swiftformat --lint .— cleanBOUNCER LISTNETWORKSand you haven't bound any networks yet — open the server console (server row in the sidebar). Banner appears with the network list and Add buttons.Risk / rollback
defaults delete <bundle>for testing or rollback.