Add Preferences > History pane with CHATHISTORY page-size knob - #27
Merged
Conversation
buggerman
force-pushed
the
preferences-history-pane
branch
from
April 25, 2026 14:18
94e13f4 to
94e02ab
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
defaults writecan't ask the server for an absurd batch.Changes
Sources/BryggaCore/PreferencesKeys.swift— newchathistoryPageSizekey +chathistoryPageSizeFallback(50) constant.Sources/BryggaCore/IRC/IRCSession.swift— newpublic static func chathistoryPageSize() -> Intthat reads + clamps the value.requestMoreHistory(for:)now calls it instead of using a hardcoded50.Sources/Brygga/Views/PreferencesView.swift— newHistoryPanetab with aPickerfor the page size and a server-support explainer. Usesclock.arrow.circlepathSF Symbol.Tests/IRCSessionTests.swift— three unit tests: fallback when unset, configured value honored, out-of-range clamping.Test plan
swift build— passesswift test— 121 tests pass (+3 new)swiftformat --lint .— cleanCHATHISTORY BEFORE <chan> <anchor> 250.defaults write <bundle-id> brygga.chathistoryPageSize -int 99999then click Load — request still uses 500 (clamped).Risk / rollback
requestMoreHistorysemantics are unchanged for users who never visit the new pane (default = previous hardcode).