fix: relax beautifulsoup4 pin to support Frappe v16 (#198)#205
Merged
Conversation
FAC pinned beautifulsoup4~=4.12.2, which locks to the 4.12.* series. Frappe v15 requires ~=4.12.2 but Frappe v16 requires ~=4.13.5, so installing FAC on a v16 bench resolved bs4 down to 4.12.x — downgrading a dependency the rest of the bench expected at 4.13.x. Relax to beautifulsoup4>=4.12,<5 so the constraint spans both Frappe v15 (4.12.x) and v16 (4.13.x) without forcing a downgrade. FAC uses bs4 only as a transitive convenience and does not depend on any 4.12-vs-4.13 behavior. Fixes #198 (Observation 1). Observation 2 (optional analytics extras) is a larger packaging change tracked separately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes Observation 1 of #198 — the
beautifulsoup4~=4.12.2pin downgrades bs4 on Frappe v16 benches.Root cause (verified against both Frappe versions)
beautifulsoup4~=4.12.2(locks to 4.12.*)beautifulsoup4~=4.13.5(locks to 4.13.*)FAC's
~=4.12.2intersects with v16's requirement only at 4.12.x, sobench get-appdowngrades bs4 from 4.13.x to 4.12.x on a v16 bench — exactly the reporter'spip freezeevidence (4.13.5 → 4.12.3).Fix
>=4.12,<5is satisfiable on both v15 (4.12.x) and v16 (4.13.x) and no longer forces a downgrade. FAC uses bs4 only as a transitive convenience and relies on no 4.12-vs-4.13 behavioral difference.Scope
This PR covers Observation 1 only. Observation 2 (moving the heavy analytics deps to an optional
[analytics]extra) is a larger, mildly-breaking packaging change with plugin-loading implications and is tracked separately.Checklist
fix:)develop