More client stuff #112
Draft
More client stuff #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should be almost never needed, but can be useful when extending the schema internally, or temprorarily re-deserializing inputs.
Avoid redundantly re-instantiating these in each GraphQL schema template instance.
Ensure declarations aliased from graphql.ast have the same name so that we can use their original name (as reported by __traits(identifier)) without having to fully qualify them.
Ahead-of-time code generation now needs these types to be accessible from outside this package.
VPanteleev-S7
force-pushed
the
client
branch
3 times, most recently
from
0761962 to
8d5a66e
Compare
This was passing the tests by accident because instantiation was failing and the tests were falling back to default Vibe.d logic, which already has very similar logic for serializing Date values.
… testing Ensure that we don't hit any default logic in serialization libraries which would mask our inability to correctly serialize/deserialize custom scalars.
If an input type field is non-null, then it must both be present and have a value other than null.
The previous approach required type-checking at runtime.
Text editors don't tend to deal with very long lines, which makes debugging a little difficult.
…calar definitions Associative arrays have issues with serializing to D literals (only very recent compiler versions support associative array constant literals).
Only a superficial unit test for now as this requires a patch that has not been merged upstream yet.
We were previously handling these correctly when they appeared as an input field, but not when they appeared directly as a variable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #111 .