fix: infer database type from DSN protocol in API sources endpoint #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using DSN-based configuration in TOML files without explicit 'type' fields, the /api/sources endpoint was failing with "missing required type field" errors. This fix allows the endpoint to work correctly with DSN-only configurations by extracting the database type from the protocol portion of the DSN string. Changes: - Add getDatabaseTypeFromDSN() utility function to dsn-obfuscate.ts - Use centralized type inference in transformSourceConfig() - Handle both 'postgres' and 'postgresql' protocols as PostgreSQL - Maintain backward compatibility with explicit type configurations Fixes API endpoint failure for DSN-only TOML configurations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue "missing required type field" with
dsnin configuration filedbhub.toml#131When using DSN-based configuration in TOML files without explicit 'type' fields, the /api/sources endpoint was failing with "missing required type field" errors. This fix allows the endpoint to work correctly with DSN-only configurations by extracting the database type from the protocol portion of the DSN string.
Changes:
Fixes API endpoint failure for DSN-only TOML configurations.