chore: fix clippy lints and cargo check warnings #395
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mostly a 'cargo clippy --fix --all-features --all-targets', plus some manual fixes for elided lifetimes.
|
Looks like a transient dep has a higher MSRV 😞 |
|
Thanks for the PR! The files tests/fs_utf8.rs, tests/net-udp.rs, and others that start with a comment "This file is derived from ..." are derived from other sources. In those files, it's more desirable to minimize diffs with the upstream sources than to fix clippy lints, so please revert the clippy changes in those files. Adding |
|
I think most of these lints have actually been fixed on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly a 'cargo clippy --fix --all-features --all-targets',
plus some manual fixes for elided lifetimes.