-
Notifications
You must be signed in to change notification settings - Fork 67
Expand WIT overview section #288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for expanding this section! Left a bunch of comments, mostly nits
Co-authored-by: Victor Adossi <[email protected]>
Co-authored-by: Victor Adossi <[email protected]>
Co-authored-by: Victor Adossi <[email protected]>
Co-authored-by: Victor Adossi <[email protected]>
Co-authored-by: Victor Adossi <[email protected]>
Co-authored-by: Victor Adossi <[email protected]>
Co-authored-by: Victor Adossi <[email protected]>
Co-authored-by: Victor Adossi <[email protected]>
Co-authored-by: Victor Adossi <[email protected]>
Co-authored-by: Victor Adossi <[email protected]>
Co-authored-by: Victor Adossi <[email protected]>
Co-authored-by: Victor Adossi <[email protected]>
Co-authored-by: Victor Adossi <[email protected]>
Co-authored-by: Victor Adossi <[email protected]>
Co-authored-by: Victor Adossi <[email protected]>
component-model/src/design/wit.md
Outdated
We've explained how worlds and interfaces | ||
define how components relate to each other. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably can remove this -- someone may land on this page without going to the other ones, I think.
If we want to refer to the previous section, then we maybe could include a link and a statement that is more general/doesn't expect the transition from the previous page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed in 81c91ef
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost there! Thanks for addressing all the previous suggestions!
component-model/src/design/wit.md
Outdated
The WIT (Wasm Interface Type) language is used to define Component Model [interfaces](#interfaces) and [worlds](#worlds). | ||
WIT isn't a general-purpose programming language and doesn't define behaviour; | ||
it defines only _contracts_ between components. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These two lines feel like they should be the first ones
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed in 81c91ef
Co-authored-by: Victor Adossi <[email protected]>
Most of the changes here are to add semantic line breaks, but I did expand on some concepts, particularly resources.