Add socket_peerpidfd
#1474
Open
Add socket_peerpidfd
#1474
+50
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Supported on Linux since 6.5.
|
|
sunfishcode
reviewed
Jun 29, 2025
| @@ -277,6 +278,7 @@ fn test_select_with_sockets() { | |||
| #[test] | |||
| #[serial] // for `setrlimit` usage, and `crate::init` | |||
| fn test_select_with_maxfd_sockets() { | |||
| use rustix::fd::{FromRawFd as _, OwnedFd}; | |||
There was a problem hiding this comment.
I'm curious why these lines were needed in the tests, that weren't otherwise changed.
There was a problem hiding this comment.
That fixes a compile error with cargo test --features net,process,event. Though it also works to use --features=all-apis like CI uses. (I suppose ideally it shouldn't error for any combination of features; but doesn't matter that much for tests.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supported on Linux since 6.5.
I see
socket_peercredis only provided on Linux, while OpenBSD (https://man.openbsd.org/getsockopt.2) has some version ofSO_PEERCRED, and FreeBSD (https://man.freebsd.org/cgi/man.cgi?unix(4)) has aLOCAL_PEERCRED(libwayland for instance has code to use those on their respective platforms). These APIs do seem to be slightly different though. In any case,SO_PEERPIDFDis definitely Linux-specific for the time being.