Skip to content

chore(serde): fix conditional compilation #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fibonacci1729 merged 2 commits into from
Aug 26, 2025
Merged

chore(serde): fix conditional compilation #178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
599a96e
chore(serde): fix serde conditional compilation
billf Aug 24, 2025
517651c
chore(github): run cargo check against workspace
billf Aug 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,15 +39,17 @@ jobs:
rustup default stable
shell: bash
- name: Build without default features
run: cargo check --no-default-features
run: cargo check --workspace --no-default-features
- name: Build the `wat` feature
run: cargo check --no-default-features --features wat
run: cargo check --workspace --no-default-features --features wat
- name: Build the `wit` feature
run: cargo check --no-default-features --features wit
run: cargo check --workspace --no-default-features --features wit
- name: Build the `registry` feature
run: cargo check --no-default-features --features registry
run: cargo check --workspace --no-default-features --features registry
- name: Build the `serde` feature
run: cargo check --workspace --no-default-features --features serde
- name: Build all features
run: cargo check --all-features
run: cargo check --workspace --all-features

rustfmt:
name: Format source code
Expand Down
2 changes: 1 addition & 1 deletion crates/wac-types/src/component.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ impl fmt::Display for WorldId {
pub struct ModuleTypeId(Id<ModuleType>);

#[cfg(feature = "serde")]
impl serde::Serialize for ModuleId {
impl serde::Serialize for ModuleTypeId {
fn serialize<S: serde::Serializer>(&self, serializer: S) -> Result<S::Ok, S::Error> {
self.0.index().serialize(serializer)
}
Expand Down
Loading