add check for invalid reftype #4300
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Septa2112
requested review from
loganek,
lum1n0us,
no1wudi,
TianlongLiang,
wenyongh,
xujuntwt95329 and
yamt
as code owners
lum1n0us
reviewed
May 29, 2025
| @@ -820,7 +820,7 @@ load_init_expr(WASMModule *module, const uint8 **p_buf, const uint8 *buf_end, | |||
| #else | |||
| cur_value.gc_obj = NULL_REF; | |||
|
|
|||
| if (!is_byte_a_type(type1) | |||
| if (!is_byte_a_type(type1) || !wasm_is_type_reftype(type1) | |||
There was a problem hiding this comment.
Seems not quite fitting the spec requirement: https://webassembly.github.io/gc/core/valid/instructions.html#xref-syntax-instructions-syntax-instr-ref-mathsf-ref-null-mathit-ht. it requires a heaptype instead.
I know that our GC implementation doesn't sync up with the latest GC spec. Please help me confirm that the new condition combination equals heaptype. TWO types of heaptype need to be covered. https://webassembly.github.io/gc/core/binary/types.html#heap-types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
reftypevalidation inload_init_exprwhenref.null.