use BTreeMap instead of HashMap in async_support::FutureState
#1339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of this writing, initializing the default hasher for `HashMap` requires calling `wasi_snapshot_preview1:random_get`, which requires initializing the `wasi_snapshot_preview1` adapter when targeting `wasm32-wasip2` and later, and that's expensive enough that we'd prefer to avoid it for apps which otherwise make no use of the adapter. Signed-off-by: Joel Dice <[email protected]>
alexcrichton
approved these changes
Jul 16, 2025
Merged
via the queue into
bytecodealliance:main
with commit Jul 16, 2025
73bcd58
18 of 19 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of this writing, initializing the default hasher for
HashMaprequires callingwasi_snapshot_preview1:random_get, which requires initializing thewasi_snapshot_preview1adapter when targetingwasm32-wasip2and later, and that's expensive enough that we'd prefer to avoid it for apps which otherwise make no use of the adapter.