Skip to content

Conversation

@diarmidmackenzie
Copy link
Member

@diarmidmackenzie diarmidmackenzie commented Jan 4, 2023

This PR updates all examples to A-Frame 1.4.0, and fixes various issues arising:

  • THREE.Math -> THREE.MathUtils
  • Move from aframe-teleport-controls (old, unmaintained, broken in A-Frame 1.4.0) to blink-controls (maintained).
  • A workaround for A-Frame issue 5203 (which looks like a regression in 1.4.0).
  • Patch ammo-debug-drawer to addresses various THREE deprecations (would be nice to move to 1.0.1, but that uses ES6-style import/export, so needs PR Move builds from browserify to webpack #22

Of the issues found upgrading to 1.4.0, the ones that aren't fixed are:

The branch that includes this PR is temporarily published at:
https://diarmidmackenzie.github.io/aframe-physics-system/examples/

@diarmidmackenzie diarmidmackenzie marked this pull request as ready for review January 4, 2023 18:55
Copy link
Member

@vincentfretin vincentfretin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes looks good, I added some comments. I just reviewed the changes in this PR, I didn't test the examples myself.

@diarmidmackenzie diarmidmackenzie merged commit daf2633 into c-frame:master Jan 5, 2023
@diarmidmackenzie diarmidmackenzie deleted the update-examples-to-1.4.0 branch January 5, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants