Avoids HTTPS/HTTP conflicts, and linking to out-of-date documentation. #35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincentfretin
requested changes
Apr 15, 2023
There was a problem hiding this comment.
Thanks for the contribution.
I'm not sure why you have changes in dist/aframe-physics-system.js it's hard to tell. If this is just some comments, can you please remove the dist from the PR so we can just merge the documentation changes? We'll recreate the dist on next release.
For now please revert the --ssl option, it fails on Ubuntu 22.04. It's better to continue on the switch to webpack in the other PR #22.
|
Links confirmed working properly on https://github.com/c-frame/aframe-physics-system/blob/master/AmmoDriver.md |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoids HTTPS/HTTP conflicts, and linking to out-of-date documentation.