-
Notifications
You must be signed in to change notification settings - Fork 30
Migrate to pyproject.toml
, update min Python to 3.9, consolidate dev workflows
#209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
0fc8a71
to
88f1398
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #209 +/- ##
==========================================
- Coverage 54.90% 54.65% -0.25%
==========================================
Files 9 10 +1
Lines 1692 1685 -7
==========================================
- Hits 929 921 -8
- Misses 763 764 +1 ☔ View full report in Codecov by Sentry. |
So what is the plan here? Should we just merge this and see if it works, and then fix any issues? |
Only question I had was the empty |
... also - what is the plan for changing the files to ruff? Is that a second PR? I guess I thought that would come before this PR, not after. |
Sounds good. Any particular issues that you're concerned about?
This makes
I think this PR first and then #210 would be good. Once this is merged, #210 should only be 2 commits so shouldn't be a need to rebase |
ed9ac1f
to
2114d7d
Compare
using `hatch new --init` https://stackoverflow.com/q/72832052/15545258
Migrate all developer installation details to a single conda environment file
Update every month
2114d7d
to
f0eed7a
Compare
Changes:
pyproject.toml
conf.py
tests.yml
tests.utils
to consolidate test path parametersCan we add pre-commit CI* to this project, as well as set up docs building for PRs via RTD**?
* In preparation for when we add pre-commit config in next PR
** I think this is a better way to check that the docs build. It allows previewing the docs as well (which I don't think the circleci build did).