Add web support #135
Open
Add web support #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds support for web apps because browsers only speak grpc-web, not grpc. grpc-dart supports grpc-web via GrpcOrGrpcWebClientChannel which works just like the previously used ClientChannel when not on web.
|
I'm tracking my efforts to get a proxy working in nickmeinhold#1 The next step will be to add a test that runs a local server with an envoy proxy like they do in grpc-dart/test/grpc_web_test.dart |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds support for web apps because browsers only speak
grpc-web, not grpc.
We now use GrpcOrGrpcWebClientChannel which
works just like the previously used ClientChannel when not on web.
Fixes #134
I've setup an envoy proxy to test the grpc-web client but still wrestling with that a bit. I'd like to set up a test that uses the emulator and a local docker container that could be run in CI. It would be good to get feedback on #136 then if you agree I could do that first then create tests for this PR.