remove ActiveClusters from error types

Author: taylanisikdemir

common/cache/domainCache_test.go

@@ -332,7 +332,8 @@ func Test_IsActiveIn(t *testing.T) {
 				DomainName:     "test-domain",
 				CurrentCluster: "A",
 				ActiveCluster:  "B",
-				ActiveClusters: []string{"B"},
+				// TODO(active-active): After ActiveClusters field is introduced, uncomment following line
+				// ActiveClusters: []string{"B"},
 			},
 		},
 	}
@@ -1199,7 +1200,8 @@ func Test_GetActiveDomainByID(t *testing.T) {
 				DomainName:     "passive",
 				CurrentCluster: "A",
 				ActiveCluster:  "B",
-				ActiveClusters: []string{"B"},
+				// TODO(active-active): After ActiveClusters field is introduced, uncomment following line
+				// ActiveClusters: []string{"B"},
 			},
 		},
 	}

common/errors/domainNotActiveError.go

@@ -42,7 +42,11 @@ func NewDomainNotActiveError(domainName string, currentCluster string, activeClu
 		DomainName:     domainName,
 		CurrentCluster: currentCluster,
 		ActiveCluster:  activeCluster,
-		ActiveClusters: activeClusters,
+		// TODO(active-active): After ActiveClusters field is introduced, uncomment this line and update following lines
+		// - common/types/testdata/error.go
+		// - common/testing/allisset_test.go
+		// - mappers
+		// ActiveClusters: activeClusters,
 	}
 }
 

common/types/shared.go

@@ -2010,11 +2010,10 @@ func (v *DomainInfo) GetUUID() (o string) {
 // this is a retriable error and *must* be retried under at least
 // some circumstances due to domain failover races.
 type DomainNotActiveError struct {
-	Message        string   `json:"message"`
-	DomainName     string   `json:"domainName"`
-	CurrentCluster string   `json:"currentCluster"`
-	ActiveCluster  string   `json:"activeCluster,omitempty"`
-	ActiveClusters []string `json:"activeClusters,omitempty"`
+	Message        string `json:"message"`
+	DomainName     string `json:"domainName"`
+	CurrentCluster string `json:"currentCluster"`
+	ActiveCluster  string `json:"activeCluster,omitempty"`
 }
 
 // GetCurrentCluster is an internal getter (TBD...)
@@ -2033,14 +2032,6 @@ func (v *DomainNotActiveError) GetActiveCluster() (o string) {
 	return
 }
 
-// GetActiveClusters is an internal getter (TBD...)
-func (v *DomainNotActiveError) GetActiveClusters() (o []string) {
-	if v != nil {
-		return v.ActiveClusters
-	}
-	return
-}
-
 // DomainReplicationConfiguration is an internal type (TBD...)
 type DomainReplicationConfiguration struct {
 	ActiveClusterName string                             `json:"activeClusterName,omitempty"`
@@ -2174,10 +2165,9 @@ const (
 
 // EntityNotExistsError is an internal type (TBD...)
 type EntityNotExistsError struct {
-	Message        string   `json:"message,required"`
-	CurrentCluster string   `json:"currentCluster,omitempty"`
-	ActiveCluster  string   `json:"activeCluster,omitempty"`
-	ActiveClusters []string `json:"activeClusters,omitempty"`
+	Message        string `json:"message,required"`
+	CurrentCluster string `json:"currentCluster,omitempty"`
+	ActiveCluster  string `json:"activeCluster,omitempty"`
 }
 
 // WorkflowExecutionAlreadyCompletedError is an internal type (TBD...)

common/types/testdata/error.go

@@ -60,13 +60,11 @@ var (
 		DomainName:     DomainName,
 		CurrentCluster: ClusterName1,
 		ActiveCluster:  ClusterName2,
-		ActiveClusters: []string{ClusterName2},
 	}
 	EntityNotExistsError = types.EntityNotExistsError{
 		Message:        ErrorMessage,
 		CurrentCluster: ClusterName1,
 		ActiveCluster:  ClusterName2,
-		ActiveClusters: []string{ClusterName2},
 	}
 	WorkflowExecutionAlreadyCompletedError = types.WorkflowExecutionAlreadyCompletedError{
 		Message: ErrorMessage,