Mandychen/migrate buildkite to GitHub actions #6946
Conversation
mandyschen
requested review from
Shaddoll,
neil-xie,
davidporter-id-au,
Groxx,
shijiesheng,
jakobht,
3vilhamster,
sankari165,
dkrotx,
taylanisikdemir and
demirkayaender
as code owners
.github/workflows/ci-checks.yml
Outdated
| # - name: Check IDL submodule status (must point to master) | ||
| # run: make .idl-status # TODO: add this back in |
There was a problem hiding this comment.
please uncomment this and double check its output once PR is merged
scripts/github_actions/fossa.sh
Outdated
| @@ -0,0 +1,13 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
where do we use this file?
| @@ -0,0 +1,17 @@ | |||
| #!/bin/sh | |||
There was a problem hiding this comment.
this folder is exact copy of scripts/buildkite folder. After fully deprecating buildkite we should remember to cleanup those folders. Please add # TODO(bk-cleanup): Remove this file after fully migrated to github actions comment to all such files so we don't miss them in the future.
| with: | ||
| go-version: '1.23.4' | ||
|
|
||
| - name: Run integration profile for sqlite |
There was a problem hiding this comment.
interestingly, sqlite integration tests took longer than others in this run https://github.com/mandyschen/cadence/actions/runs/15742327622/job/44372636711
@arzonus any ideas why it is taking longer in github vs buildkite (25m vs 15m)?
There was a problem hiding this comment.
Agree, interesting. I'd like to have a few more attempts to see if that is permanent or just a test flakiness. Not sure if there is a difference in CPU/Memory between Github and Buildkite, as other tests looks fine.
@mandyschen could you please retry a few more times to see this? Can't do it.
There was a problem hiding this comment.
yes, I can but it had to rerun after a failure so its likely it was the combination of two runs that made it 25m
There was a problem hiding this comment.
Just reran, and I think it's because it fails the first time around. The screenshots show the times are about the same for attempt #2.
There was a problem hiding this comment.
Top is buildkite logs bottom is github action logs. This test in general is a bit flaky. It soft fails in the bk version (as well as the gh version) and there's a comment saying persistence tests shouldn't fail the build.
What changed?
Added Github Actions implementation to buildkite pipeline pipeline-master.yml
Why?
To keep all the pipelines in the same place
How did you test it?
Ran the pipeline through my own commits. Plan to test on different commits and compare outcomes with prior buildkite pipeline
Potential risks
Some issues aren't caught because they weren't caught in the pipeline. Some good PRs cant be merged because they were falsely caught by the pipeline
Release notes
Documentation Changes