feat: [shard-distributor]Send "draining" heartbeat on executer shutdown #7505
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gaziza Yestemirova <[email protected]>
Signed-off-by: Gaziza Yestemirova <[email protected]>
gazi-yestemirova
requested review from
3vilhamster,
Shaddoll,
davidporter-id-au,
demirkayaender,
dkrotx,
jakobht,
neil-xie,
sankari165,
shijiesheng and
taylanisikdemir
as code owners
Signed-off-by: Gaziza Yestemirova <[email protected]>
jakobht
reviewed
Dec 3, 2025
| executorID: "test-executor-id", | ||
| timeSource: timeSource, | ||
| } | ||
| } |
| t.Fatal("stopC should not be closed") | ||
| default: | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
I think we want it to be the same. In hindsight we should have just used context cancellation to stop.
Contributor
Author
There was a problem hiding this comment.
makes sense! let me update the test
Signed-off-by: Gaziza Yestemirova <[email protected]>
Signed-off-by: Gaziza Yestemirova <[email protected]>
Signed-off-by: Gaziza Yestemirova <[email protected]>
Signed-off-by: Gaziza Yestemirova <[email protected]>
jakobht
reviewed
Dec 11, 2025
| } | ||
|
|
||
| // Send the request | ||
| fmt.Println("sending the heartbeat+++") |
Member
There was a problem hiding this comment.
I think you forgot some debug code
| // Send the request | ||
| fmt.Println("sending the heartbeat+++") | ||
| response, err := e.shardDistributorClient.Heartbeat(ctx, request) | ||
| fmt.Println("response", response, err) |
Member
There was a problem hiding this comment.
I think you forgot some debug code
Signed-off-by: Gaziza Yestemirova <[email protected]>
jakobht
approved these changes
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed?
Why?
Shard-distributor should be notified about the executors that are shutting down to reassign the shards and keep track of ownership.
How did you test it?
unit-tests and local testing with etcd
Potential risks
Release notes
Documentation Changes