Fixing bug on calling CRUDCollection and other improvements. #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the bug when calling res.collection(items, listOptions) instead of res.collection(items, listOptions.key) Fixes a bug (link not generated) when the value of the key given is a falsy value Incorporates the suggestion by Kieren on adding another option to indicate if we want to use the key to return a keyed object. (Added test).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the bug when calling res.collection(items, listOptions) instead of
res.collection(items, listOptions.key)
Fixes a bug (link not generated) when the value of the key given is a falsy value
Incorporates the suggestion by Kieren on adding another option to
indicate if we want to use the key to return a keyed object. (Added
test).