-
Notifications
You must be signed in to change notification settings - Fork 19
feat: added support for async-storage-plugin #81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
feat: added support for async-storage-plugin #81
Conversation
|
@kagrawal98 is attempting to deploy a commit to the Callstack Team on Vercel. A member of the Team first needs to authorize it. |
|
I wonder if it would make more sense to generalize the MMKV plugin so that it accepts any kind of storage conforming to a Storage interface, and then provide adapters for MMKV, AsyncStorage, or any other storage solutions. That way, one could write: WDYT? |
@V3RON Thanks for the suggestion — I think that makes a lot of sense 👍. At a high level, the structure could look like:
UI-wise, we could have a single “Storage” panel with tabs or a scope switcher inside for each adapter/instance. That keeps things discoverable, but also lets users work with a specific store when they need to. Happy to start by landing the AsyncStorage plugin as a separate wrapper and then refactor toward this core+adapter setup if that sounds like a good path forward ? |
|
This pull request has been marked as stale because it has been inactive for 30 days. Please update this pull request or it will be automatically closed in 14 days. |
|
Sorry for the long delay @kagrawal61!
Do you mean you'd like to release this new plugin and then deprecate it in favor of a more 'generalized' one? Personally, I'd prefer refactoring the existing mmkv plugin to use this architecture and then renaming it. That way, we'd have a single codebase, and we wouldn't need to keep both in sync whenever something changes. |
Description
This PR introduces a new AsyncStorage plugin for Rozenite, providing comprehensive inspection and management capabilities for AsyncStorage data within React Native DevTools.
Features
Testing
The plugin has been tested in the playground app with various types of data stored in AsyncStorage, including strings, numbers, booleans, objects, and arrays.
How to use
Dependencies
Visuals