fix(ios): clean up Voltra event monitoring on reload#191
Merged
Conversation
Use RCTInvalidating to tear down iOS event monitoring and prevent stale native event callbacks from surviving Metro reloads.
V3RON
force-pushed
the
fix/ios-voltra-invalidating
branch
from
013c207 to
dcb327a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this?
This PR fixes an iOS native lifecycle issue where Voltra event monitoring can survive a Metro reload and keep stale native event callbacks alive. When ActivityKit delivers a token or state event after reload, those stale callbacks can reach the old React Native event emitter path and crash the example app.
How does it work?
NativeVoltranow conforms toRCTInvalidatingand tears down monitoring frominvalidateinstead of relying ondealloc. Its event handler weakly captures the module instance and ignores events after invalidation. The Voltra event bus also replaces its NotificationCenter observer cleanly, and Live Activity monitoring stops any existing manager before installing a new one.Why is this useful?
This makes the iOS event pipeline resilient to Metro reloads and prevents old ActivityKit observers from calling into a previous React Native runtime. It also gives Voltra a clearer native-module cleanup path that matches React Native New Architecture lifecycle expectations.