Skip to content

Fix NLP package resolution in tests#1830

Merged
callumalpass merged 1 commit into
mainfrom
fix-nlp-core-ci
Apr 26, 2026
Merged

Fix NLP package resolution in tests#1830
callumalpass merged 1 commit into
mainfrom
fix-nlp-core-ci

Conversation

@callumalpass
Copy link
Copy Markdown
Owner

Summary

  • Bump tasknotes-nlp-core to 0.1.1, which publishes both ESM and CommonJS package exports
  • Remove the Jest mapper that forced tests to resolve tasknotes-nlp-core from a local sibling checkout
  • Add an unreleased note for the CI dependency-resolution fix

Test plan

  • npm test -- tests/unit/services/NaturalLanguageParser.test.ts tests/unit/settings/TabButtons.css-classes.test.ts
  • npm run typecheck
  • git diff --check
  • npm run test:ci -- --runInBand --silent
  • OBSIDIAN_PLUGIN_PATH=/home/calluma/testvault/test/.obsidian/plugins/tasknotes npm run build:test
  • obsidian plugin:reload id=tasknotes vault=test

Obsidian dev errors only showed the existing advanced-canvas errors, not TaskNotes errors.

@callumalpass callumalpass merged commit e43757e into main Apr 26, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant