fix: strip time component in default base template date comparisons#1838
Open
loukandr wants to merge 1 commit intocallumalpass:mainfrom
Open
fix: strip time component in default base template date comparisons#1838loukandr wants to merge 1 commit intocallumalpass:mainfrom
loukandr wants to merge 1 commit intocallumalpass:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
today()returns midnight in the Bases formula language, so day-level comparisons intasks-default.basefail for any value with a time component. A task scheduled for today at a non-midnight time (e.g.15:45) is excluded from the Today view becausedate(scheduled) == today()evaluates<today> 15:45 == <today> 00:00→ false. The same issue affects>= today()and<= today() + "Nd"checks across several formulas.Reported in #1124.
Repro
scheduled: 2027-01-15T15:45(use today's date, any non-midnight time).tasks-default.base.Fix
Add
.date()to strip the time component before comparing, matching theisDueTodayandisScheduledTodayformulas in the same file.Affected:
isDueThisWeek,isThisWeek,dueDateCategory,nextDateCategory,dueDateDisplay< today()comparisons (Overdue branches) are left as-is, they evaluate correctly without.date().Tests
Extended
tests/unit/templates/defaultBasesFiles.test.tswith positive pins for the affected formulas and negative matchers against the time-naive shapes.Fixes #1124