-
Notifications
You must be signed in to change notification settings - Fork 747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: adding MinerU Extractor #1529
base: master
Are you sure you want to change the base?
Conversation
note for self: add tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi GitHoobar! Thanks you for the nice contribution!
Overall it looks good! I left some comments, please take a look!
I am still requesting for the API key, so I am unable to run the examples, maybe other reviewers can double check with the examples.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @GitHoobar 's great contribution! Overall looks great, left some comments below~
Description
adding MinerU extractor
Motivation and Context
Why is this change required? What problem does it solve?
close #1521
Types of changes
What types of changes does your code introduce? Put an
x
in all the boxes that apply:Implemented Tasks
Checklist
Go over all the following points, and put an
x
in all the boxes that apply.If you are unsure about any of these, don't hesitate to ask. We are here to help!