Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Added tests to increase test coverage of models #1550

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Rkejji
Copy link
Collaborator

@Rkejji Rkejji commented Feb 4, 2025

Description

Added unit test to models while mocking API calls to the real openai API.

Motivation and Context

This PR is related to this issue #1513

  • I have raised an issue to propose this change (required for new features and bug fixes)

Types of changes

What types of changes does your code introduce? Put an x in all the boxes that apply:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds core functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (update in the documentation)
  • Example (update in the folder of example)

Implemented Tasks

  • Subtask 1
  • Subtask 2
  • Subtask 3

Checklist

Go over all the following points, and put an x in all the boxes that apply.
If you are unsure about any of these, don't hesitate to ask. We are here to help!

  • I have read the CONTRIBUTION guide. (required)
  • My change requires a change to the documentation.
  • I have updated the tests accordingly. (required for a bug fix or a new feature)
  • I have updated the documentation accordingly.

@Rkejji Rkejji requested a review from Wendong-Fan February 4, 2025 15:43
@Rkejji Rkejji force-pushed the test/add_models_tests branch from 0516356 to 0546514 Compare February 4, 2025 18:11
@Rkejji Rkejji requested a review from lightaime February 4, 2025 18:13
@Rkejji Rkejji force-pushed the test/add_models_tests branch 4 times, most recently from 59b3410 to 69cbbca Compare February 9, 2025 19:20
Copy link
Member

@Wendong-Fan Wendong-Fan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @Rkejji for the great contribution!
for deepseek model we removed the part so now there's one error to be fixed:
https://github.com/camel-ai/camel/actions/runs/13228863991/job/36923215735?pr=1550
could you look into this part and let me know if there's anything I can support~

@Rkejji Rkejji force-pushed the test/add_models_tests branch from 69cbbca to e9c1552 Compare February 10, 2025 09:10
@Rkejji
Copy link
Collaborator Author

Rkejji commented Feb 10, 2025

thanks @Rkejji for the great contribution! for deepseek model we removed the part so now there's one error to be fixed: https://github.com/camel-ai/camel/actions/runs/13228863991/job/36923215735?pr=1550 could you look into this part and let me know if there's anything I can support~

It is done, the issue was due to the fact that the GET_REASONING_CONTENT env variable was not declared in the CI. I declared it in the test let me know if you prefer to have it in the CI instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants