Skip to content

Use parameterized test #792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Use parameterized test #792

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
89 changes: 17 additions & 72 deletions ...com/github/cameltooling/lsp/internal/completion/modeline/CamelKModelineInsertionTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,8 @@
import org.eclipse.lsp4j.jsonrpc.messages.Either;
import org.junit.jupiter.api.Nested;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.ValueSource;

import java.util.List;
import java.util.concurrent.CompletableFuture;
Expand Down Expand Up @@ -96,32 +98,14 @@ class FileWithCommentsTest {

@Nested
class XMLTest {
@Test
void testProvideInsertionOnCommentedXMLFile() throws Exception {
FileType type = FileType.XML;
String contents = "<!-- One comment -->\n";
Position position = beginningOfLastLine(contents);

List<CompletionItem> completionItems = getCompletionsFor(type, contents, position);

assertCompletionItemsHasExpectedCompletionForType(type, completionItems);
}

@Test
void testProvideInsertionOnMultipleCommentsXMLFile() throws Exception {
FileType type = FileType.XML;
String contents = "<!-- One comment --><!-- Moar comments -->\n";
Position position = beginningOfLastLine(contents);

List<CompletionItem> completionItems = getCompletionsFor(type, contents, position);

assertCompletionItemsHasExpectedCompletionForType(type, completionItems);
}

@Test
void testProvideInsertionOnMultipleCommentsOnMultipleLinesXMLFile() throws Exception {
@ParameterizedTest
@ValueSource(strings = {
"<!-- One comment -->\n",
"<!-- One comment --><!-- Moar comments -->\n",
"<!-- One comment -->\n \n <!-- Moar comments -->\n"
})
void testProvideInsertionOnCommentedXMLFile(String contents) throws Exception {
FileType type = FileType.XML;
String contents = "<!-- One comment -->\n \n <!-- Moar comments -->\n";
Position position = beginningOfLastLine(contents);

List<CompletionItem> completionItems = getCompletionsFor(type, contents, position);
Expand Down Expand Up @@ -179,54 +163,15 @@ void testDontProvideInsertionIfExtraTextYAML() throws Exception {

@Nested
class JavaTest {
@Test
void testProvideInsertionOnLineCommentedJavaFile() throws Exception {
FileType type = FileType.Java;
String contents = "// Example\n";
Position position = beginningOfLastLine(contents);

List<CompletionItem> completionItems = getCompletionsFor(type, contents, position);

assertCompletionItemsHasExpectedCompletionForType(type, completionItems);
}

@Test
void testProvideInsertionOnMultipleLineCommentedJavaFile() throws Exception {
FileType type = FileType.Java;
String contents = "// Example\n \n //Example //Example \n //EEExample \n";
Position position = beginningOfLastLine(contents);

List<CompletionItem> completionItems = getCompletionsFor(type, contents, position);

assertCompletionItemsHasExpectedCompletionForType(type, completionItems);
}

@Test
void testProvideInsertionOnBlockCommentedJavaFile() throws Exception {
FileType type = FileType.Java;
String contents = "/* Example */\n";
Position position = beginningOfLastLine(contents);

List<CompletionItem> completionItems = getCompletionsFor(type, contents, position);

assertCompletionItemsHasExpectedCompletionForType(type, completionItems);
}

@Test
void testProvideInsertionOnMultipleBlockCommentedJavaFile() throws Exception {
FileType type = FileType.Java;
String contents = "/* Example\n \n Example */ /*Example \n EEExample */ \n";
Position position = beginningOfLastLine(contents);

List<CompletionItem> completionItems = getCompletionsFor(type, contents, position);

assertCompletionItemsHasExpectedCompletionForType(type, completionItems);
}

@Test
void testProvideInsertionOnMixCommentedJavaFile() throws Exception {
@ParameterizedTest
@ValueSource(strings = {
"// Example\n",
"// Example\n \n //Example //Example \n //EEExample \n",
"/* Example */\n",
"/* Example\n \n Example */ /*Example \n EEExample */ \n",
"/* Example\n \n Example */ /*Example \n //EEExample */ \n"})
void testProvideInsertionOnCommentedFile(String contents) throws Exception {
FileType type = FileType.Java;
String contents = "/* Example\n \n Example */ /*Example \n //EEExample */ \n";
Position position = beginningOfLastLine(contents);

List<CompletionItem> completionItems = getCompletionsFor(type, contents, position);
Expand Down