ENHANCEMENT Subscribe allowed to work stand alone

[camfindlay]

This allows subscribes to work even if the developer doesn't implement a frontend form to trigger the initial subscription.

This will allow Mailchimp sync on any existing registration forms or via the CMS.

Will only run the sync if the Member isSubscribed OR if their status is false (which indicates they are not on the list and should be added).

[camfindlay]

Can you check my logic here @tractorcow I found an issue if the Member existed in SIlverStripe and not in Mailchimp and either the Member was updated via CMS or when using the MemberProfiles module (as it bypassed the API because the isSubscribed was always false).

[tractorcow]

Should you check not only for listStatus = false, but also listStatus = pending?

[camfindlay]

thanks @tractorcow good point as they could be waiting for confirm so we shouldn't trigger another subscribe call. I'll make the change.

[camfindlay]

See if this is acceptable @tractorcow can you see any issues with it's use on ss.org?

[tractorcow]

I would have done it the other way around... if a subscription is pending, and then the update their details, and following that approve their subscription, I would expect to see their updated details included. I think it's ok to subscribeUser during the pending process, since it only updates their personal details.

It doesn't trigger another subscription confirmation (from memory), but you can check that if you like.