Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new function that allows to create noupdate records #50

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add a new function that allows to create noupdate records #50

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
64ecf38
Add a new function that allows to create a noupdate record
mmequignon Feb 4, 2020
45af30e
fixup! Add a new function that allows to create a noupdate record
mmequignon Feb 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions anthem/lyrics/records.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,18 @@ def add_xmlid(ctx, record, xmlid, noupdate=False):
})


def create(ctx, model, xmlid, values, noupdate=False):
""" Create a record matching xmlid with values """
if isinstance(model, basestring):
model = ctx.env[model]

record = ctx.env.ref(xmlid, raise_if_not_found=False)
if not record:
record = model.create(values)
add_xmlid(ctx, record, xmlid, noupdate)
return record
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, we want the songs to be idempotent, so create is not a good player in this regard. Why not extending create_or_update with a noupdate argument?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because a noupdate record shouldn't be updated.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, idempotence is guaranteed by the if not record condition.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 with @guewen You can extending create_or_update function.
noupdateflag don't indicate that we never want to update a record.
It indicates we don't want update the record automatically with a module update.
Here, you call "manually" the create_or_update function, so if you don't want to update an existing record, just don't call the create_or_update function if record already exists.

Also, I would like to understand why you need this feature here.

  • If you need a "module" record with noupdate, you create it directly in your module with noupdate.
  • If you need an external record like __setup__.***, you just need to check in your script if the record exists before create it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense to me that a noupdate field can't be updated, I created a dedicated function for that reason. But that's not a big deal, I'll do whatever you want me to do.



def create_or_update(ctx, model, xmlid, values):
""" Create or update a record matching xmlid with values """
if isinstance(model, basestring):
Expand Down