Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: consider environment variables #57

Closed
wants to merge 3 commits into from

Conversation

unki2aut
Copy link
Contributor

@unki2aut unki2aut commented Mar 8, 2023

When this pytest plugin is used within the Odoo Docker image, we have to take the database configuration from the environment variables. On normal Docker image execution this configuration is done by the entrypoint.sh.

This also addresses issue #39

Copy link
Member

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG. Minor remark.

Co-authored-by: Simone Orsi <[email protected]>
@yvaucher
Copy link
Member

Merged at 765c84b

(added a slight change in README and a docstring)

@yvaucher yvaucher closed this Dec 15, 2023
@unki2aut
Copy link
Contributor Author

Merged at 765c84b

(added a slight change in README and a docstring)

Sad, that you made your own commit, therefore I get no contribution, but great that you accepted the feature 🙂

@yvaucher
Copy link
Member

Sir, you have a commit with you as the author. Only the merge commit is attributed to me.

4975895

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants