Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snap package hooks #411

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

matthew-hagemann
Copy link

@matthew-hagemann matthew-hagemann commented Dec 4, 2024

Adds support for apport to search /snap/<snap-name>/current/apport/package-hooks for package hooks.

Currently there are several package-hooks the desktop team have in apport itself.

This will allow for easier apport integration for snap packagers, and allow us to move special case
snap hooks out of /usr/share/apport/package-hooks/ in the future, making them easier to iterate on by including package hooks in the snap packaging.

Adds support for apport to search /snap/<snap-name>/current/apport/package-hooks for package hooks.
This will allow for easier apport integration for snap packagers, and allow us to move special case
snap hooks out of /usr/share/apport/package-hooks/ in the future.
@matthew-hagemann matthew-hagemann marked this pull request as ready for review December 4, 2024 15:54
@bdrung
Copy link
Collaborator

bdrung commented Dec 6, 2024

Thanks for your contribution, but there is a security issue: The snap hook is run outside of its container, which would defeat the purpose of snaps.

Copy link
Collaborator

@bdrung bdrung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We cannot trust the hook provided by the snap. If we want to run hooks from snaps, those hooks need to run in the context of the snap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants