Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui: drop unneeded int conversion in run_hang #443

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bdrung
Copy link
Collaborator

@bdrung bdrung commented Feb 19, 2025

The method UserInterface.run_hang requires pid to be of type int.

@bdrung bdrung marked this pull request as draft February 19, 2025 12:43
Copy link

codecov bot commented Feb 19, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 30.02%. Comparing base (e18ec92) to head (312cdcf).
Report is 7 commits behind head on main.

Files with missing lines Patch % Lines
apport/ui.py 0.00% 3 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (e18ec92) and HEAD (312cdcf). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (e18ec92) HEAD (312cdcf)
2 1
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #443       +/-   ##
===========================================
- Coverage   83.60%   30.02%   -53.59%     
===========================================
  Files         101       85       -16     
  Lines       20451    19178     -1273     
  Branches     3219     2890      -329     
===========================================
- Hits        17098     5758    -11340     
- Misses       2858    12938    +10080     
+ Partials      495      482       -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

The method `UserInterface.run_hang` requires `pid` to be of type `int`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant