Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy load elements in base apport module #475

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bdrung
Copy link
Collaborator

@bdrung bdrung commented Mar 14, 2025

For faster module loading and to avoid circular dependencies, load all elements in the base apport module in a lazy fashion.

Copy link

codecov bot commented Mar 14, 2025

Codecov Report

Attention: Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.92%. Comparing base (3164b24) to head (a4ab24d).

Files with missing lines Patch % Lines
apport/__init__.py 89.47% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #475   +/-   ##
=======================================
  Coverage   83.92%   83.92%           
=======================================
  Files         101      101           
  Lines       20455    20471   +16     
  Branches     3215     3215           
=======================================
+ Hits        17167    17181   +14     
- Misses       2839     2842    +3     
+ Partials      449      448    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bdrung bdrung marked this pull request as draft March 14, 2025 19:13
For faster module loading and to avoid circular dependencies, load all
elements in the base `apport` module in a lazy fashion.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant