Rename apport/packaging.py to apport/package_info.py #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`import apport.packaging` will not import `apport/packaging.py` but `packaging` from `apport/__init__.py` instead. To avoid this name clash name the Python file identical to the class it defines. It is expected that no Python code outside of Apport uses `from apport.packaging import PackageInfo`. Fixes: 8763b83 ("Changed the packaging backend import, [...]")
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #477 +/- ##
===========================================
- Coverage 83.69% 30.05% -53.65%
===========================================
Files 101 85 -16
Lines 20443 19157 -1286
Branches 3216 2887 -329
===========================================
- Hits 17110 5757 -11353
- Misses 2839 12920 +10081
+ Partials 494 480 -14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
import apport.packagingwill not importapport/packaging.pybutpackagingfromapport/__init__.pyinstead. To avoid this name clash name the Python file identical to the class it defines.It is expected that no Python code outside of Apport uses
from apport.packaging import PackageInfo.Fixes: 8763b83 ("Changed the packaging backend import, [...]")