Deprecate logging functions in base apport module #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lazy load logging functions in base apport module for faster module loading.
Deprecate using the logging functions directly from the base `apport` module. Users should import the logging functions from `apport.logging` instead.
bdrung
force-pushed
the
deprecate-apport-logging
branch
from
dde8b95 to
d2effc0
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #481 +/- ##
==========================================
+ Coverage 83.92% 83.93% +0.01%
==========================================
Files 101 101
Lines 20444 20459 +15
Branches 3215 3217 +2
==========================================
+ Hits 17157 17172 +15
Misses 2839 2839
Partials 448 448 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate using the logging functions directly from the base
apportmodule. Users should import the logging functions fromapport.logginginstead.