report: add support for YAQL expressions in bug patterns #485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogayot
force-pushed
the
with-yaql-bugpattern
branch
from
2b77dc4 to
2dd579d
Compare
|
I'll need to gracefully handle the absence of the |
ogayot
force-pushed
the
with-yaql-bugpattern
branch
from
2dd579d to
b80a85e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #485 +/- ##
==========================================
- Coverage 83.92% 82.44% -1.48%
==========================================
Files 101 99 -2
Lines 20455 20474 +19
Branches 3215 3159 -56
==========================================
- Hits 17167 16880 -287
- Misses 2839 3114 +275
- Partials 449 480 +31 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Bug patterns have historically only supported executing regular expressions. This is ok for log files and simple strings, but when we have access to more structured data (i.e., JSON or YAML) in bug reports, having the ability to find elements in such files is very useful. In addition to regular expressions, we now support YAQL expressions in bug patterns. They can be specified using the following syntax: <pattern url="https://launchpad.net/bugs/XXX"> <re key="package">subiquity</re> <yaql key="ProbeData"> [ YAQL expression ] </yaql> </pattern> The format attribute can optionally be specified and will control the parser used. Supported values are "yaml" (the default) and "json". The YAML parser can parse JSON but is slightly slower, thus specifying format="json" is recommended for JSON files. Patterns having <yaql> tags will be considered non-matches if the yaql python module is not installed.
ogayot
force-pushed
the
with-yaql-bugpattern
branch
from
b80a85e to
e97565f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug patterns have historically only supported executing regular expressions. This is ok for log files and simple strings, but when we have access to more structured data (i.e., JSON or YAML) in bug reports, having the ability to find elements in such files is very useful.
In particular, this would be beneficial for Subiquity, where we have a large number of bug reports that we currently de-duplicate manually. We want to rely more on automation for such tasks.
In addition to regular expressions, we now support YAQL expressions [1] in bug patterns. They can be specified using the following syntax:
The format attribute can optionally be specified and will control the parser used. Supported values are
"yaml"(the default) and"json".The YAML parser can parse JSON but is slightly slower, thus specifying
format="json"is recommended for JSON files.Patterns having
<yaql>tags will be considered non-matches if theyaqlpython module is not installed.https://yaql.readthedocs.io/en/latest/getting_started.html