test: add unshare crash test case #486
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Calling `data/apport` via `subprocess.check_call` will not be covered by coverage. Call into the `data/apport` code directly to get it covered. pytest will fail with PermissionError and INTERNALERROR on cleanup when running all integration tests as root. So keep using `subprocess.check_call` for tests that set a different UID.
Rename the helper method `wait_for_gdb_sleeping_child_process` to `wait_for_gdb_child_process` and allow specifying the expected status instead of hard-coding searching for the `sleep` state. Also query the GDB child processes recursively. This change allows detecting processes that kill themselves.
Refactor the helper function `create_dropsuid` into `compile_c_code` to allow reusing the code for compiling other test executables.
Add an unshare crash test case that is a stripped down version of a crash inside a container. This test case add code coverage to the `FileNotFoundError` exception code path in `forward_crash_to_container`. See also LP #2080499.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #486 +/- ##
==========================================
- Coverage 83.92% 82.51% -1.42%
==========================================
Files 101 99 -2
Lines 20455 20401 -54
Branches 3215 3152 -63
==========================================
- Hits 17167 16833 -334
- Misses 2839 3089 +250
- Partials 449 479 +30 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an unshare crash test case that is a stripped down version of a crash inside a container. This test case add code coverage to the
FileNotFoundErrorexception code path inforward_crash_to_container. See also LP #2080499.This merge request depends on #484.