apport: catch ProcessLookupError in forward_crash_to_container #487
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Crashes in the Chrome snap can crash Apport:
```
Traceback (most recent call last):
File "/usr/share/apport/apport", line 1248, in <module>
sys.exit(main(sys.argv[1:]))
^^^^^^^^^^^^^^^^^^
File "/usr/share/apport/apport", line 773, in main
if _check_global_pid_and_forward(options):
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/usr/share/apport/apport", line 732, in _check_global_pid_and_forward
forward_crash_to_container(options)
File "/usr/share/apport/apport", line 531, in forward_crash_to_container
sock_fd = os.open(
^^^^^^^^
ProcessLookupError: [Errno 3] No such process: 'root/run/apport.socket'
```
Example /proc/cmdline:
```
/usr/bin/python3 /usr/share/apport/apport -p1 -s4 -c0 -d1 -P570846 -u1000 -g1000 -- !snap!chromium!2934!usr!lib!chromium-browser!chrome
/usr/bin/python3 /usr/share/apport/apport -p1 -s4 -c0 -d1 -P22550 -u1001 -g1001 -- !snap!brave!438!opt!brave.com!brave!brave
```
The Snap container does neither have `/run` nor /run/apport.socket`.
Python throws `ProcessLookupError` instead of `FileNotFoundError`. So
catch this exception type as well. Writing a test case for this use case
is tricky unless you want to setup snaps in your test environment.
Bug-Ubuntu: https://launchpad.net/bugs/2080499
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #487 +/- ##
=======================================
Coverage 83.92% 83.92%
=======================================
Files 101 101
Lines 20455 20455
Branches 3215 3215
=======================================
Hits 17167 17167
- Misses 2839 2840 +1
+ Partials 449 448 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Crashes in the Chrome snap can crash Apport:
Example /proc/cmdline:
The Snap container does neither have
/runnor /run/apport.socket. Python throwsProcessLookupErrorinstead ofFileNotFoundError`. So catch this exception type as well. Writing a test case for this use case is tricky unless you want to setup snaps in your test environment.Bug-Ubuntu: https://launchpad.net/bugs/2080499