DO NOT MERGE: Test juju 4 with jubilant tests#192
Draft
DO NOT MERGE: Test juju 4 with jubilant tests#192
Conversation
…162) ## Description of issue or feature: - Adds integration tests for metrics (#102 ) - Begins integration test rewrites for [Jubliant](https://github.com/canonical/jubilant). Rewrites test_charm.py to use Jubilant. ## Solution: - Introduces three tests for metrics integration to `test_charm.py` to verify direct metrics scrape, integration with grafana-agent and COS-lite & prometheus respectively. - Rewrites existing tests in test_charm.py, as well as the helpers functions they invoke, to use Jubliant. ## How was this change tested? - [x] Manually (to verify jubliant models created and destroyed) - [ ] Unit tests - [x] Integration tests <!--- Please describe in detail how you tested your changes. --> <!--- Include details of your testing environment, and the tests you ran to --> <!--- see how your change affects other areas of the code, etc. --> --------- Co-authored-by: René Radoi <[email protected]>
* test: rewrites tls tests to use jubilant * refactor: minor fixes * fix: secret identifier to use uri, not name * fix: secret identifier to use uri, not name * fix: unit count check * fix: test initialize vault * refactor: lint * fix: vault decoding * fix: vault decoding and refactor * fix: vault decoding and refactor * fix: vault decoding and refactor * fix: refactor and address comments * refactor: review comments; readability vs abstraction tradeoff * refactor: address review comments * fix: minor bugfix * fix: minor bugfix * test: minor bugfix * test: bugfix * fix: minor correction
…ion-tests # Conflicts: # tests/integration/client_relations/test_client_relations.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft PR to run available jubilant integration tests against Juju 4.0
THIS PR MUST NOT BE MERGED!