Skip to content

ci: support libs with requires-python higher than 3.10#366

Merged
james-garner-canonical merged 5 commits intocanonical:mainfrom
james-garner-canonical:26-03+ci+fix-python-version-selection-in-init
Mar 17, 2026
Merged

ci: support libs with requires-python higher than 3.10#366
james-garner-canonical merged 5 commits intocanonical:mainfrom
james-garner-canonical:26-03+ci+fix-python-version-selection-in-init

Conversation

@james-garner-canonical
Copy link
Collaborator

@james-garner-canonical james-garner-canonical commented Mar 17, 2026

#364 has revealed that CI breaks with packages with a requires-python lower bound that's higher than 3.10 (it has requires-python>=3.12).

This is because we would run just integration-k8s and just integration-machine in the init step to check if they have any tests, and that uses our default justfile Python version of 3.10.

This PR fixes this by recording the minimum supported Python version when we calculate the Python versions to test the library with, and using that version in the failing step.

@james-garner-canonical james-garner-canonical marked this pull request as ready for review March 17, 2026 22:14
@james-garner-canonical james-garner-canonical requested a review from a team as a code owner March 17, 2026 22:14
Copy link
Contributor

@tonyandrewmeyer tonyandrewmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@james-garner-canonical james-garner-canonical merged commit 1cf92b0 into canonical:main Mar 17, 2026
311 checks passed
james-garner-canonical added a commit that referenced this pull request Mar 18, 2026
We tried to fix this in #366, but missed that we need to use the
detected minimum Python version in the `integration` job as well as in
`init`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants