ci: support libs with requires-python higher than 3.10#366
Merged
james-garner-canonical merged 5 commits intocanonical:mainfrom Mar 17, 2026
Conversation
This was referenced Mar 17, 2026
james-garner-canonical
added a commit
that referenced
this pull request
Mar 18, 2026
We tried to fix this in #366, but missed that we need to use the detected minimum Python version in the `integration` job as well as in `init`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#364 has revealed that CI breaks with packages with a
requires-pythonlower bound that's higher than 3.10 (it hasrequires-python>=3.12).This is because we would run
just integration-k8sandjust integration-machinein theinitstep to check if they have any tests, and that uses our defaultjustfilePython version of 3.10.This PR fixes this by recording the minimum supported Python version when we calculate the Python versions to test the library with, and using that version in the failing step.