Skip to content

chore(tls-certificates): migrate the integration tests to Jubilant#367

Open
tonyandrewmeyer wants to merge 2 commits intocanonical:mainfrom
tonyandrewmeyer:chore/migrate-tls-certificates-to-jubilant
Open

chore(tls-certificates): migrate the integration tests to Jubilant#367
tonyandrewmeyer wants to merge 2 commits intocanonical:mainfrom
tonyandrewmeyer:chore/migrate-tls-certificates-to-jubilant

Conversation

@tonyandrewmeyer
Copy link
Contributor

@tonyandrewmeyer tonyandrewmeyer commented Mar 17, 2026

Migrates the tls-certificates interface integration tests from python-libjuju to Jubilant (and pytest-operator to pytest-jubilant).

Initial work done with AI but then manually reviewed by me.

@tonyandrewmeyer tonyandrewmeyer marked this pull request as ready for review March 17, 2026 21:53
@tonyandrewmeyer tonyandrewmeyer requested a review from a team as a code owner March 17, 2026 21:53
@james-garner-canonical
Copy link
Collaborator

WDYT about reducing churn by doing this after the imminent pytest-jubilant 2.0 release?

I also wondered if TLS might prefer to hold off until they migrate their charm integration tests so they're not doing things two different ways at once, but this may not be a real concern.

@tonyandrewmeyer
Copy link
Contributor Author

WDYT about reducing churn by doing this after the imminent pytest-jubilant 2.0 release?

I can bump it after that. I wonder if there are actually any changes that would break here anyway?

I also wondered if TLS might prefer to hold off until they migrate their charm integration tests so they're not doing things two different ways at once, but this may not be a real concern.

They're welcome to reject the PR or hold off on it, of course. Or, even better, migrate the charm integration tests too - this is partly a demo of how straightforward migration can be (see the transcript linked in the description).

Copy link
Contributor

@dimaqq dimaqq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this.
I think it's an improvement and shows how tests can be migrated.
(still need a TLS review obv.)

Copy link
Contributor

@saltiyazan saltiyazan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you for making the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants